[hooks] Rename HookOutputBuilder.addDependency
#2503
Conversation
PR Health
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| code_assets | Breaking | 0.19.5 | 0.19.6-wip | 0.20.0 Got "0.19.6-wip" expected >= "0.20.0" (breaking changes) |
|
| data_assets | Breaking | 0.19.2 | 0.19.3-wip | 0.20.0 Got "0.19.3-wip" expected >= "0.20.0" (breaking changes) |
|
| hooks | Breaking | 0.20.0 | 0.20.1-wip | 0.21.0 Got "0.20.1-wip" expected >= "0.21.0" (breaking changes) |
|
| hooks_runner | Breaking | 0.22.0 | 0.22.1-wip | 0.23.0 Got "0.22.1-wip" expected >= "0.23.0" (breaking changes) |
|
| native_toolchain_c | Breaking | 0.17.1 | 0.17.1 | 0.18.0 Got "0.17.1" expected >= "0.18.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/jni/lib/src/third_party/generated_bindings.dart |
| pkgs/objective_c/lib/src/ns_input_stream.dart |
| output, | ||
| ) async { | ||
| output.addDependency(packageRootUri.resolve('foo')); | ||
| output.dependencies.add(packageRootUri.resolve('foo')); |
There was a problem hiding this comment.
I understand the aesthetic reasoning behind this but as a user now I would at least expect dependencies to be an Iterable.
There was a problem hiding this comment.
It's a builder, only when you use .build() you get the built value where you can access the values you've added. It's how the whole API is structured.
(I'm happy to receive feedback on the API as a whole, you can give it a spin and file usability issues. Then we can address those in separate PRs.)
dcharkes
force-pushed
the
dependencies-add
branch
from
ec1ae13 to
9a48b1c
Compare
|
autosubmit label was removed for dart-lang/native/2503, because - The status or check suite build (macos, dev) has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for dart-lang/native/2503, because - The status or check suite build (macos, dev) has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Test failure is unrelated: |
2 participants
For the other collections in the output we have a
output.foo.addandoutput.foo.addAll. Alignoutput.addDependencyto beoutput.dependencies.add.