Skip to content

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Sep 10, 2025

This is purely a plumbing change.

Fixes #2462
Yak shaving for #2419

@github-actions
Copy link

github-actions bot commented Sep 10, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
jni Breaking 0.14.2 0.15.0-wip 0.15.0 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Sep 10, 2025

Coverage Status

coverage: 81.314% (+0.4%) from 80.915%
when pulling 6091ce7 on ffigen_typewriter
into 76d519a on main.

@HosseinYousefi
Copy link
Member

Is this still a draft or is it ready to review?

Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself seems trivial so LGTM nevertheless

@liamappelbe liamappelbe marked this pull request as ready for review September 10, 2025 23:32
@liamappelbe
Copy link
Contributor Author

Is this still a draft or is it ready to review?

Oops, forgot to mark it ready

@liamappelbe liamappelbe merged commit 813edba into main Sep 10, 2025
40 checks passed
@liamappelbe liamappelbe deleted the ffigen_typewriter branch September 10, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ffigen] Type to string converters should not take a Writer

3 participants