Skip to content

Conversation

@liamappelbe
Copy link
Contributor

It's only used for its bool enabled field, and it's confusing to have part of the config copied into these objects when it's also available from the Context.

Yak shaving for #2419

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Sep 11, 2025

Coverage Status

coverage: 82.9% (-0.01%) from 82.913%
when pulling ba5a23f on ffigen_native_config
into 813edba on main.

@liamappelbe liamappelbe merged commit 8668b55 into main Sep 11, 2025
46 of 47 checks passed
@liamappelbe liamappelbe deleted the ffigen_native_config branch September 11, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants