Skip to content

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Oct 16, 2025

I'm doing this as part of updating https://dart.dev/interop/objective-c-interop. Migrating the rest of the yaml configs is lower priority.

Also, add xcodePath, iosSdkPath, and macSdkPath to the public API. These getters expose the variable substitutions available in the YAML config: $XCODE, $IOS_SDK, and $MACOS_SDK.

@github-actions
Copy link

github-actions bot commented Oct 16, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Oct 16, 2025

Coverage Status

coverage: 89.778% (+0.02%) from 89.76%
when pulling 752aebb on ffigen_example
into b17023d on main.

@liamappelbe liamappelbe requested a review from dcharkes October 16, 2025 03:23
@liamappelbe liamappelbe marked this pull request as ready for review October 16, 2025 03:24
@liamappelbe liamappelbe requested review from HosseinYousefi and removed request for dcharkes October 16, 2025 08:03
@liamappelbe liamappelbe merged commit f7c7d52 into main Oct 17, 2025
36 of 37 checks passed
@liamappelbe liamappelbe deleted the ffigen_example branch October 17, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants