Skip to content

Conversation

GregoryConrad
Copy link
Contributor

Certain Rust projects utilize bindgen to generate Rust bindings from C headers. bindgen in turn uses clang-sys, which utilizes libclang's shared library (much like Dart's ffigen, AFAIK). clang-sys looks in a few default locations for this shared library, but is not always able to find it. In such situations (e.g., in a Nix-based install), the developer must set LIBCLANG_PATH to point to the shared library's location.

Thus, adding this variable to the allowlist.

CC @dcharkes

@GregoryConrad GregoryConrad changed the title Add LIBCLANG_PATH to hooks env-var allowlist [hooks_runner] Add LIBCLANG_PATH to environment variable allowlist Oct 18, 2025
Copy link

github-actions bot commented Oct 19, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
hooks_runner None 0.23.1 0.23.2 0.23.1 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Oct 19, 2025

Coverage Status

coverage: 82.006% (-10.0%) from 91.972%
when pulling 1cdf57b on GregoryConrad:patch-1
into f7c7d52 on dart-lang:main.

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:code_assets 0.19.8 already published at pub.dev
package:data_assets 0.19.3 already published at pub.dev
package:ffi 2.1.5-wip WIP (no publish necessary)
package:hooks 0.20.4 already published at pub.dev
package:hooks_runner 0.23.2 ready to publish hooks_runner-v0.23.2
package:native_toolchain_c 0.17.2 already published at pub.dev
package:swift2objc 0.1.0 already published at pub.dev
package:swiftgen 0.1.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@dcharkes dcharkes merged commit 85a5d14 into dart-lang:main Oct 20, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants