[ffigen] Remove unnecessary ignore_for_files

[goderbauer]

FFIgen automatically generates // ignore_for_file: type=lint, so manually specifying additional lints to ignore has no further effect. This PR cleans up those additional ignores.

[github-actions]

PR Health

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbol	Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

[coveralls]

coverage: 82.341% (+0.6%) from 81.779%
when pulling 5ba016b on goderbauer:headercleanup
into efb2c2c on dart-lang:main.

[goderbauer]

(The is about the import a few lines below for package:ffi, but github wouldn't let me comment there)

Now that this example is analyzes (see changes in pkgs/ffigen/analysis_options.yaml) the analyzer complains about this import being unused (this is a warning, not a lint, and hence not covered by the ignore_for_file below):

warning • Unused import: 'package:ffi/ffi.dart' • example/objective_c/avf_audio_bindings.dart:11:8 • unused_import

@liamappelbe Is it expected that FFIgen generates this import even if it is unused?

[goderbauer]

Working around this for now by adding // ignore_for_file: unused_import to the preamble. But I think FFIgen shouldn't be generating this import in the first place...

[liamappelbe]

@liamappelbe Is it expected that FFIgen generates this import even if it is unused?

Ideally no, but it's a lot harder to guarantee that now that we're searching for used libraries as a visitor rather than during code generation. The PR has a more detailed explanation.

[liamappelbe]

Filed a bug: #2748

[goderbauer]

(This comment is about the import on line 17, but github wouldn't let me comment on that line.)

Same problem here.

[auto-submit]

autosubmit label was removed for dart-lang/native/2747, because - The status or check suite analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.