Skip to content

Conversation

@HosseinYousefi
Copy link
Member

Closes #2781.

@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:jni labels Nov 14, 2025
@github-actions
Copy link

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
jni None 0.15.1 0.15.2 0.15.1 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@coveralls
Copy link

coveralls commented Nov 14, 2025

Coverage Status

coverage: 87.445%. remained the same
when pulling 72f854c on dont-fail-on-desktop
into 5501355 on main.

Copy link
Contributor

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HosseinYousefi HosseinYousefi merged commit dea1bf3 into main Nov 14, 2025
30 checks passed
@HosseinYousefi HosseinYousefi deleted the dont-fail-on-desktop branch November 14, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:jni type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[jni] Silently ignore build failure on other platform in absence of JDK

4 participants