Skip to content

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Nov 17, 2025

The params were being renamed to avoid keyword collisions etc, but we were still using the originalName. Switching to just use the renamed name works, but means that params with no name get named unnamed, which is verbose. So I've changed it to use the name unless the originalName is empty.

Fixes #2795

@github-actions
Copy link

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@liamappelbe liamappelbe marked this pull request as ready for review November 17, 2025 01:16
@liamappelbe liamappelbe merged commit 9439bfb into main Nov 18, 2025
34 checks passed
@liamappelbe liamappelbe deleted the ffigen_2795 branch November 18, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 ffigen: Struct member function pointer does **not** rename reserved keyword parameters (top-level functions correctly do)

2 participants