[native_toolchain_c] Fix clang compiler search + tools when using swiftly
#2800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftly proxies commands to some of the tools that ship with Swift distributions, including: `clang`, `ld.lld`, and other tools. Therefore, such tools are symlinks to `swiftly`, and running `swiftly` directly would therefore not work when bundling assets. This PR adds support for using `package:native_toolchain_c` on macOS with Swiftly installed, defaulting to the user's default installation of `ar` and `ld` where applicable.
nikeokoronkwo
changed the title
swiftly
dcharkes
approved these changes
Nov 18, 2025
Collaborator
There was a problem hiding this comment.
Thanks @nikeokoronkwo !
It would require some additions to current tool resolving and behavior, so I was considering it on a separate PR than this one.
👍
If it is possible to have swiftly on the CI here in GitHub, you could consider adding an extra github workflow that covers it. We also run the CI an extra time in .github/workflows/native_toolchain_c.yaml to cover a different toolchain than the default ones.
And also, please add some tests that tools don't resolve at all on Linux/Windows.
(And version + changelog entry so I can hit publish after merging 😄)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2792
Swiftly proxies commands to some of the tools that ship with Swift distributions, including:
clang,ld.lld, and other tools. Therefore, such tools are symlinks toswiftly, and runningswiftlydirectly would therefore not work when bundling assets.This PR adds support for using
package:native_toolchain_con macOS with Swiftly installed, defaulting to the user's default installation ofarandldwhere applicable.I assume that in realistic use-cases, users would want to use specific toolchains and therefore, would want to use tools together rather than distinct instances of certain tools (i.e. prefer
ldbundled with the currently resolvedclangthan a separate use ofld), and most users would prefer using the Clang distribution they already have in their system rather than that bundled with Swiftly, so I'm considering a separate PR for using a different clang toolchain than that Swiftly has. It would require some additions to current tool resolving and behavior, so I was considering it on a separate PR than this one.