-
Notifications
You must be signed in to change notification settings - Fork 86
[native_toolchain_c] Include missing errors output using Level.INFO when running CL #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you add a test or change an existing test to see that your change has the desired effect? |
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
CL outputs error-related messages to the standard output. This patch allows outputting these errors to the user while preserving the current level of logging for other toolchains. Include `createCapturingRecordLogger` utility to check the level of a `LogRecord`, otherwise the test would always succeed. Closes dart-lang#2809
ca07411 to
132221d
Compare
I added a test + changelog + pubspec, it should be all good now. |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
dcharkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @poirierlouis ! 🙏
CL outputs error-related messages to the standard output. This patch allows outputting these errors to the user while preserving the current level of logging for other toolchains.
Closes #2809
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.