Skip to content

Conversation

@poirierlouis
Copy link
Contributor

CL outputs error-related messages to the standard output. This patch allows outputting these errors to the user while preserving the current level of logging for other toolchains.

Closes #2809


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@dcharkes
Copy link
Collaborator

Could you add a test or change an existing test to see that your change has the desired effect?

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/example/command_line/lib/main.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_toolchain_c None 0.17.3 0.17.4 0.17.3 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@coveralls
Copy link

coveralls commented Nov 21, 2025

Coverage Status

coverage: 81.832% (-5.1%) from 86.974%
when pulling 132221d on poirierlouis:fix/missing-logs
into 224d93e on dart-lang:main.

CL outputs error-related messages to the standard output. This patch allows outputting these errors to the user while preserving the current level of logging for other toolchains.
Include `createCapturingRecordLogger` utility to check the level of a `LogRecord`, otherwise the test would always succeed.

Closes dart-lang#2809
@poirierlouis
Copy link
Contributor Author

Could you add a test or change an existing test to see that your change has the desired effect?

I added a test + changelog + pubspec, it should be all good now.

@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:code_assets 1.0.0 already published at pub.dev
package:data_assets 0.19.6 already published at pub.dev
package:ffi 2.1.5-wip WIP (no publish necessary)
package:hooks 1.0.0 already published at pub.dev
package:hooks_runner 1.0.0 already published at pub.dev
package:native_toolchain_c 0.17.4 ready to publish native_toolchain_c-v0.17.4
package:swift2objc 0.1.0 already published at pub.dev
package:swiftgen 0.1.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @poirierlouis ! 🙏

@dcharkes dcharkes merged commit 73b32c4 into dart-lang:main Nov 21, 2025
22 checks passed
@poirierlouis poirierlouis deleted the fix/missing-logs branch November 21, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[windows] [build-hook] Logging is incomplete/inaccurate when running with CBuilder

3 participants