-
Notifications
You must be signed in to change notification settings - Fork 87
[ffigen] Support concurrent tests #2827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
dcharkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet to see this long standing TODO being addressed! 😄
… into ffigen_concurrent_tests
The main fix was to stop setting
Directory.current. Luckily this only happened in thewithChDiruntil, so it was easy to remove. For the most part that worked without any other changes. The only exception was the libclang-example test, which was relying on relative file paths in their extra clang command line options.Also had to stop using
Logger.rootin the test context.Fixes #461