Skip to content

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Nov 26, 2025

The main fix was to stop setting Directory.current. Luckily this only happened in the withChDir until, so it was easy to remove. For the most part that worked without any other changes. The only exception was the libclang-example test, which was relying on relative file paths in their extra clang command line options.

Also had to stop using Logger.root in the test context.

Fixes #461

@coveralls
Copy link

coveralls commented Nov 26, 2025

Coverage Status

coverage: 81.978% (+0.009%) from 81.969%
when pulling 7ed5dbc on ffigen_concurrent_tests
into 1391b39 on main.

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/hooks_runner/test_data/download_assets/hook/build.dart
pkgs/objective_c/example/command_line/lib/main.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@liamappelbe liamappelbe changed the title WIP: [ffigen] Support concurrent tests [ffigen] Support concurrent tests Nov 26, 2025
@liamappelbe liamappelbe marked this pull request as ready for review November 26, 2025 02:40
@liamappelbe liamappelbe requested a review from dcharkes November 26, 2025 02:40
Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet to see this long standing TODO being addressed! 😄

@liamappelbe liamappelbe merged commit 579b84d into main Nov 26, 2025
33 checks passed
@liamappelbe liamappelbe deleted the ffigen_concurrent_tests branch November 26, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable concurrency in CI tests

3 participants