Skip to content

[native_assets_cli] Require dirs to exist #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2023
Merged

[native_assets_cli] Require dirs to exist #40

merged 2 commits into from
May 15, 2023

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented May 15, 2023 •
edited
Loading

HosseinYousefi
HosseinYousefi approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the build is failing for some reason though!

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label May 15, 2023
@dcharkes
Copy link
Collaborator Author 

Err:1 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 gcc-11-aarch64-linux-gnu-base amd64 11.3.0-1ubuntu1~22.04cross1
  503  Service Unavailable [IP: 40.119.46.219 80]

Same issue for me, and simply running an apt-get update before installing anything fixed it.

@coveralls
Copy link

coveralls commented May 15, 2023 •
edited
Loading

Coverage Status

coverage: 99.848%. remained the same
when pulling 3d3acc9 on outdir-exists
into 64aa5b5 on main.

@dcharkes dcharkes merged commit e01aa63 into main May 15, 2023
@dcharkes dcharkes deleted the outdir-exists branch May 15, 2023 12:36
@HosseinYousefi HosseinYousefi mentioned this pull request May 15, 2023
Merged
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@dcharkes
[native_assets_cli] Require dirs to exist (#40)
3e07829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HosseinYousefi HosseinYousefi HosseinYousefi approved these changes

@mkustermann mkustermann Awaiting requested review from mkustermann

Assignees

No one assigned

Labels

package:hooks type-infra A repository infrastructure change or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcharkes @coveralls @HosseinYousefi