Skip to content

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Jun 6, 2023

Adds a dry_run option to the native assets CLI, and makes the c_compiler package respect it.

Issue:

@coveralls
Copy link

coveralls commented Jun 6, 2023

Coverage Status

coverage: 99.404% (+0.003%) from 99.401%
when pulling 88b875e on dry-run
into c851e69 on main.

@dcharkes dcharkes requested a review from HosseinYousefi June 6, 2023 10:14
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dcharkes!

@dcharkes dcharkes merged commit 973f3ed into main Jun 6, 2023
@dcharkes dcharkes deleted the dry-run branch June 6, 2023 10:27
@dcharkes
Copy link
Collaborator Author

dcharkes commented Jun 6, 2023

tyvm @HosseinYousefi !

HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants