Skip to content

[native_asset_cli] Trim dry_run of architecture, build_mode, etc. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

[native_asset_cli] Trim dry_run of architecture, build_mode, etc. #66

merged 1 commit into from
Jun 13, 2023

Conversation

@dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Jun 12, 2023 •
edited
Loading

Addresses the remaining concerns in:

@dcharkes dcharkes changed the title Trim-dry-run [native_asset_cli] Trim dry_run of architecture, build_mode, etc. Jun 12, 2023
@coveralls
Copy link

coveralls commented Jun 12, 2023 •
edited
Loading

Coverage Status

coverage: 99.523% (+0.2%) from 99.341%
when pulling e681d84 on trim-dry-run
into 78cf286 on main.

@dcharkes dcharkes marked this pull request as ready for review June 12, 2023 18:57
@dcharkes dcharkes requested a review from HosseinYousefi June 12, 2023 18:58
@dcharkes
Copy link
Collaborator Author

@HosseinYousefi feel free to postpone reviewing until after #65 is merged and this rebased to reduce the diff.

HosseinYousefi
HosseinYousefi approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dcharkes!

@dcharkes dcharkes merged commit 2de8813 into main Jun 13, 2023
@dcharkes dcharkes deleted the trim-dry-run branch June 13, 2023 15:22
@dcharkes
Copy link
Collaborator Author

Thanks @HosseinYousefi ! 🚀

HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
@HosseinYousefi
[jnigen] Generic support (#136)
1f004e6 
Added support for Generics – Closed #66, Closed #73 

* TypeClasses are now public and have `fromRef`
* Casting is possible between different types.
* Nested generic classes are also supported.
HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
@HosseinYousefi
[jnigen] Generic support (#136)
5749250 
Added support for Generics – Closed #66, Closed #73 

* TypeClasses are now public and have `fromRef`
* Casting is possible between different types.
* Nested generic classes are also supported.
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@dcharkes
[native_assets_cli] Trim dry run (#66)
fac1e20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HosseinYousefi HosseinYousefi HosseinYousefi approved these changes

Assignees

No one assigned

Labels

package:hooks package:native_toolchain_c

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dcharkes @coveralls @HosseinYousefi