Skip to content

[native_assets_cli] Don't read c_compiler config if dry_run #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

[native_assets_cli] Don't read c_compiler config if dry_run #68

merged 1 commit into from
Jun 14, 2023

Conversation

@dcharkes
Copy link
Collaborator

No description provided.

@dcharkes dcharkes requested a review from HosseinYousefi June 14, 2023 09:31
@HosseinYousefi
Copy link
Member

Thanks @dcharkes 🚗💨

@coveralls
Copy link

coveralls commented Jun 14, 2023 •
edited
Loading

Coverage Status

coverage: 99.523%. remained the same
when pulling 0e5c5e8 on fix-to-yaml-late-init-error
into 2de8813 on main.

@dcharkes dcharkes merged commit c80be90 into main Jun 14, 2023
@dcharkes dcharkes deleted the fix-to-yaml-late-init-error branch June 14, 2023 09:41
@dcharkes
Copy link
Collaborator Author

Thanks for the ⚡ speed review! @HosseinYousefi 🙇‍♂️

HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@dcharkes
[native_assets_cli] Don't read c_compiler config if dry_run (#68)
fa7b822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HosseinYousefi HosseinYousefi HosseinYousefi approved these changes

Assignees

No one assigned

Labels

package:hooks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcharkes @HosseinYousefi @coveralls