Skip to content

[jnigen] Fix flaky tests #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 21, 2023
Merged

[jnigen] Fix flaky tests #814

merged 6 commits into from
Nov 21, 2023

Conversation

@HosseinYousefi
Copy link
Member

  • Actually awaiting Isolate.run
  • Increasing the time limit for binding generation tests

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Nov 20, 2023
dcharkes
dcharkes approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dcharkes
dcharkes reviewed Nov 21, 2023
View reviewed changes
@coveralls
Copy link

coveralls commented Nov 21, 2023 •
edited
Loading

Coverage Status

coverage: 90.813%. remained the same
when pulling 6461b77 on fix-flaky-jni-test
into 7d9fbf3 on main.

@HosseinYousefi HosseinYousefi merged commit 3153a35 into main Nov 21, 2023
@HosseinYousefi HosseinYousefi deleted the fix-flaky-jni-test branch November 21, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcharkes dcharkes dcharkes approved these changes

Assignees

No one assigned

Labels

type-infra A repository infrastructure change or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HosseinYousefi @coveralls @dcharkes