Skip to content

Fixing license match post-filtering calculation with traling contained range. #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

Fixing license match post-filtering calculation with traling contained range. #1489

merged 1 commit into from
Sep 29, 2025

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Sep 29, 2025

  • Fixes License recognition fails on SSH-OpenSSH #1484.
  • The findLongestUnclaimedTokenRange is used to filter out detection results where the unclaimed/unrecognized range is too long (50+ tokens), however, with trailing contained ranges the calculation is wrong.
  • Related to License detection overlap removal fails #1488, as the contained range is a smaller version of the license. In such cases we should also remove the smaller version, but in that case the edge case bug here wouldn't be noticeable.

@isoos isoos requested a review from sigurdm September 29, 2025 12:00
@isoos isoos merged commit e636152 into dart-lang:master Sep 29, 2025
4 of 5 checks passed
@isoos isoos deleted the unclaimed branch September 29, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

License recognition fails on SSH-OpenSSH

2 participants

@isoos @sigurdm