-
Notifications
You must be signed in to change notification settings - Fork 44
Run third_party/spdx/update_licenses.dart
#1514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sigurdm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! I had no clue we were so far behind.
@isoos are you happy?
| If the Library as you received it specifies that a proxy can decide whether future versions of the GNU Lesser General Public License shall | ||
| apply, that proxy's public statement of acceptance of any version is permanent authorization for you to choose that version for the Library. | ||
|
|
||
| GNU GENERAL PUBLIC LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
including the GPL in the LGPL is optional: https://spdx.org/licenses/LGPL-3.0-or-later.html
however this is not modeled by this code, so the similarity goes way down
|
I think adding the additional licenses are great, but the LGPL additional content breaks the detection of them, and we have a sizeable amount of packages that already use LGPL-3.0. Let's revert the changes in those files, and keep the rest (esp. new files)! |
|
Define "those files"? LGPL-3.0 has a big diff, the other LGPLs don't. Some other files also have big diff (e.g. some CC-*). Should I revert all files with a diff, and only keep additions? Or just LGPT-3.0? |
To keep it simple, let's add only the new files and revert updated license texts. Optional, but maybe it would be worth to also add a simple test in #1105 is still relevant, we need to have better/reliable way to update the license texts without worrying on such add-on content, but that can come later. |
|
Thanks! It may take some time until this reaches pub.dev, probably next week the earliest. |
|
Do updates reprocess existing packages, or do I need to wait with my next publish? |
The analysis will be repeated (on the latest and some other versions), no need for publishing a new version for it. |
Fixes #1513