Migrate tests in frontend/backend.dart #2638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
requested changes
Aug 7, 2019
Member
jonasfj
left a comment
jonasfj
left a comment
There was a problem hiding this comment.
Let's fix the exception, otherwise I think this is good to ship.
Collaborator
Author
I'm not sure what to fix here, maybe a comment did not get through? |
isoos
force-pushed
the
migrate-backend-tests
branch
from
f7f2fcd to
1b4b735
Compare
jonasfj
reviewed
Aug 8, 2019
jonasfj
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1595