Use hosted memcache alpha #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
mkustermann
reviewed
Sep 8, 2017
Member
mkustermann
left a comment
mkustermann
left a comment
There was a problem hiding this comment.
The only necessary change in order to switch to hosted memcache is the small change in Dockerfile.
Please keep it that simple.
app/pubspec.yaml
Outdated
Member
There was a problem hiding this comment.
Please don't make PRs with things that should not be committed!
Member
Author
There was a problem hiding this comment.
See WIP in the title – hoping folks pay attention before hitting merge – it was an easy way to share and discuss the change.
Member
Author
Yup. Wanted to try out a few other things while hacking... |
kevmoo
force-pushed
the
memcache_silly
branch
from
7960112 to
a4630df
Compare
Member
Author
|
@mkustermann – PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should wait for dart-archive/appengine#71 to land and a publish
...but wanted to show that this works