Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Jun 26, 2024

Reduces external network traffic for dynamically downloaded Flutter SDKs.

@isoos isoos requested review from jonasfj and sigurdm June 26, 2024 16:09
@isoos
Copy link
Collaborator Author

isoos commented Jun 26, 2024

This is an interesting failure: on my machine, I think the two kind of setup produces the same SDK directory (as far as I can tell), yet, the behavior is different. I think we should update pana logging to include the output of failed processes in log.txt to debug this further.


# Download and extract Flutter SDK
cd "$WORK_DIR"
curl -sS "https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_$2-${CHANNEL}.tar.xz" >flutter.tar.xz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we consider using -o and some retry options?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better done in a separate PR :D

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on different PR, but what kind of options would you like to see here?

@isoos isoos force-pushed the flutter-setup branch 2 times, most recently from 6f34013 to a2bc0d7 Compare June 28, 2024 13:30
@isoos isoos merged commit dbdfa8f into dart-lang:master Jun 28, 2024
@isoos isoos deleted the flutter-setup branch June 28, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants