Skip to content

Download counts: fix date formatting in file name #7840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Download counts: fix date formatting in file name #7840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7487858
Download counts: fix date formatting in file name
szakarias Jul 1, 2024
73c1d37
move method
szakarias Jul 1, 2024
890f825
comment
szakarias Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/lib/service/download_counts/sync_download_counts.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ Future<void> syncDownloadCounts() async {
final syncDate = today.addCalendarDays(-i);
final fileName = [
'daily_download_counts',
'${syncDate.year}-${syncDate.month}-${syncDate.day}T00:00:00Z',
formatDateForFileName(syncDate),
'data-000000000000.jsonl',
].join('/');
final success = await processDownloadCounts(fileName, syncDate);
Expand All @@ -153,7 +153,7 @@ Future<void> syncDownloadCounts() async {
}
final yesterdayFileName = [
'daily_download_counts',
'${yesterday.year}-${yesterday.month}-${yesterday.day}T00:00:00Z',
formatDateForFileName(yesterday),
'data-000000000000.jsonl',
].join('/');

Expand All @@ -171,3 +171,9 @@ Future<void> syncDownloadCounts() async {
}
}
}

String formatDateForFileName(DateTime date) {
final month = date.month.toString().padLeft(2, '0');
final day = date.day.toString().padLeft(2, '0');
return '${date.year}-$month-${day}T00:00:00Z';
}
19 changes: 9 additions & 10 deletions app/test/service/download_counts/download_counts_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ void main() {
final date = today.addCalendarDays(-i);
final fileName = [
'daily_download_counts',
'${date.year}-${date.month}-${date.day}T00:00:00Z',
formatDateForFileName(date),
'data-000000000000.jsonl',
].join('/');
await generateFakeDownloadCounts(
Expand Down Expand Up @@ -235,7 +235,7 @@ void main() {
final date = today.addCalendarDays(-i);
final fileName = [
'daily_download_counts',
'${date.year}-${date.month}-${date.day}T00:00:00Z',
formatDateForFileName(date),
'data-000000000000.jsonl',
].join('/');
await generateFakeDownloadCounts(
Expand Down Expand Up @@ -271,15 +271,14 @@ void main() {
messages,
contains('Failed to read '
'"daily_download_counts/'
'${yesterday.year}-${yesterday.month}-${yesterday.day}'
'T00:00:00Z/data-000000000000.jsonl".'));
'${formatDateForFileName(yesterday)}'
'/data-000000000000.jsonl".'));
expect(
messages,
contains(
'Download counts sync was partial. The following files failed:\n'
'[daily_download_counts/'
'${yesterday.year}-${yesterday.month}-${yesterday.day}'
'T00:00:00Z/data-000000000000.jsonl]'));
'[daily_download_counts/${formatDateForFileName(yesterday)}'
'/data-000000000000.jsonl]'));
});

testWithProfile('Sync download counts - fail', fn: () async {
Expand All @@ -290,7 +289,7 @@ void main() {
final date = today.addCalendarDays(-i);
final fileName = [
'daily_download_counts',
'${date.year}-${date.month}-${date.day}T00:00:00Z',
formatDateForFileName(date),
'data-000000000000.jsonl',
].join('/');
await generateFakeDownloadCounts(
Expand All @@ -310,8 +309,8 @@ void main() {
exception,
'Exception: Download counts sync was partial. The following files failed:'
'[daily_download_counts/'
'${skippedDate.year}-${skippedDate.month}-${skippedDate.day}'
'T00:00:00Z/data-000000000000.jsonl]');
'${formatDateForFileName(skippedDate)}'
'/data-000000000000.jsonl]');

final countData =
await downloadCountsBackend.lookupDownloadCountData('neon');
Expand Down