compute and upload 30 day total download counts #8091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
approved these changes
Sep 30, 2024
jonasfj
approved these changes
Oct 1, 2024
app/lib/service/download_counts/compute_30_days_total_counts.dart
Outdated
Show resolved
Hide resolved
Comment on lines
14
to
28
| Future<void> compute30DaysTotalTask() async { | ||
| final allDownloadCounts = await downloadCountsBackend.listAllDownloadCounts(); | ||
| final totals = await compute30DayTotals(allDownloadCounts); | ||
| await updload30DaysTotal(totals); | ||
| } | ||
|
|
||
| Future<Map<String, int>> compute30DayTotals( | ||
| Stream<DownloadCounts> downloadCounts) async { | ||
| final res = <String, int>{}; | ||
| await for (final dc in downloadCounts) { | ||
| res[dc.package] = compute30DayTotal(dc); | ||
| } | ||
|
|
||
| return res; | ||
| } |
Member
There was a problem hiding this comment.
Why not merge these with listAllDownloadCounts, and make a single method?
Passing around streams is a bit scary, even if I think our stream will retry individual pages as it fetches the entire result.
Contributor
Author
There was a problem hiding this comment.
I think logically this is the separation that makes sense....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.