Skip to content

Migrate neutral hover background colors #8098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

Migrate neutral hover background colors #8098

merged 1 commit into from
Oct 3, 2024

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Oct 2, 2024

  • Partial reimplementation of New naming scheme for theme roles + migrating some background colors. #8064, only doing the hover background color in this PR.
  • Light theme changes:
    • sort control hover color is changed from #f5f5f7 (the inset color) into #fafafa (the consolidated hover color)
    • report page hover color is changed from #f0f0f0 into #fafafa
  • Dark theme changes:
    • #383838 and #333333 hover colors merged into #373737 (their closes named color).

@isoos isoos requested review from jonasfj and sigurdm October 2, 2024 14:42
@isoos
Copy link
Collaborator Author

isoos commented Oct 3, 2024

Note: this is now on staging.

@isoos isoos merged commit 3ee44d1 into dart-lang:master Oct 3, 2024
32 checks passed
@isoos isoos deleted the css-hover branch October 3, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isoos @sigurdm