Interface for writing exported API #8104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoos
approved these changes
Oct 11, 2024
| /// This means that it must include bucket name. | ||
| /// Such URIs can be created with [Bucket.absoluteObjectName]. | ||
| Future<void> copyFrom(String absoluteObjectName) async { | ||
| await Future.wait(_owner._prefixes.map((prefix) async { |
Collaborator
There was a problem hiding this comment.
Is it possible that we have a race condition here which may update the second object earlier? (Is that bad?) -- actually this applies for most of the similar Future.wait calls in this file...
sigurdm
reviewed
Oct 11, 2024
Co-authored-by: István Soós <isoos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for an interface for writing the exported API.
The idea is to put everything related to managing the actual objects of the bucket into a single abstraction.
This interface isn't responsible for figuring out:
Only where to write things.
The hope is that this makes it less likely that we accidentally writes file to the wrong location, forget to update them, or forget to GC particular files.