Account for sass import deprecation #8161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoos
approved these changes
Oct 18, 2024
Collaborator
|
Note: before merging this should be pushed to staging first, let me know if this is considered ready. |
Member
Author
|
@isoos Yeah that would be appreciated. More eyes to make sure there are no regressions would be helpful :) |
Collaborator
|
Tested this locally and it seems mostly okay, except for e.g. the markdown code block with highlight js in dark mode: It is not apparent to me what part is breaking... Maybe we should split the changes in the PR? |
isoos
force-pushed
the
feat/sass-import-deprecation
branch
from
92df273 to
1a9ae39
Compare
isoos
approved these changes
Jan 3, 2025
Collaborator
isoos
left a comment
isoos
left a comment
There was a problem hiding this comment.
Fixed the rendering issue by moving the embedded styles into their own _third_party.scss file.
isoos
force-pushed
the
feat/sass-import-deprecation
branch
from
1a9ae39 to
35fabea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.