Skip to content

Tests for garbage collection of package archives in exported API #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Tests for garbage collection of package archives in exported API #8197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c20c235
Tests for garbage collection of package archives in exported API
jonasfj Oct 29, 2024
20b7e3e
Fix test
jonasfj Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/lib/package/api_export/exported_api.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ final class ExportedPackage {
Future<void> garbageCollect(Set<String> allVersionNumbers) async {
await Future.wait([
..._owner._prefixes.map((prefix) async {
final pfx = '/api/archives/$_package-';
final pfx = prefix + '/api/archives/$_package-';
await _owner._listBucket(prefix: pfx, delimiter: '', (item) async {
assert(item.isObject);
if (!item.name.endsWith('.tar.gz')) {
Expand Down
47 changes: 47 additions & 0 deletions app/test/package/api_export/exported_api_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,53 @@ void main() {
);
}
});

testWithFakeTime('ExportedApi.garbageCollect()', (fakeTime) async {
await storageService.createBucket('exported-api');
final bucket = storageService.bucket('exported-api');
final exportedApi = ExportedApi(storageService, bucket);

await exportedApi.package('retry').tarball('1.2.3').write([1, 2, 3]);

await exportedApi.package('retry').tarball('1.2.4').copyFrom(
bucket,
'latest/api/archives/retry-1.2.3.tar.gz',
);

// Files are present
expect(
await bucket.readBytes('latest/api/archives/retry-1.2.3.tar.gz'),
[1, 2, 3],
);
expect(
await bucket.readBytes('latest/api/archives/retry-1.2.4.tar.gz'),
[1, 2, 3],
);

// Nothing is GC'ed after 10 mins
fakeTime.elapseSync(minutes: 10);
await exportedApi.package('retry').garbageCollect({'1.2.3'});
expect(
await bucket.readBytes('latest/api/archives/retry-1.2.3.tar.gz'),
[1, 2, 3],
);
expect(
await bucket.readBytes('latest/api/archives/retry-1.2.4.tar.gz'),
[1, 2, 3],
);

// Something is GC'ed after 2 days
fakeTime.elapseSync(days: 2);
await exportedApi.package('retry').garbageCollect({'1.2.3'});
expect(
await bucket.readBytes('latest/api/archives/retry-1.2.3.tar.gz'),
[1, 2, 3],
);
expect(
await bucket.readBytes('latest/api/archives/retry-1.2.4.tar.gz'),
isNull,
);
});
}

extension on Bucket {
Expand Down
Loading