Skip to content

Include matched prefix as part of the display options. #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

Include matched prefix as part of the display options. #8209

merged 1 commit into from
Oct 31, 2024
+12 −7

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Oct 30, 2024

#8189

deployed to staging

image

@isoos isoos requested review from jonasfj and sigurdm October 30, 2024 13:21
@jonasfj
Copy link
Member

jonasfj commented Oct 30, 2024

For the record I still think it's more natural to not display the part that triggered completion. But I don't really mind it either way 🤣

@isoos
Copy link
Collaborator Author

isoos commented Oct 30, 2024

For the record I still think it's more natural to not display the part that triggered completion. But I don't really mind it either way 🤣

I'm kind of 50-50 on this, let's wait @sigurdm's vote on it.

@isoos isoos merged commit 108d593 into dart-lang:master Oct 31, 2024
32 checks passed
@isoos isoos deleted the completion-prefix branch October 31, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasfj jonasfj jonasfj approved these changes

@sigurdm sigurdm Awaiting requested review from sigurdm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isoos @jonasfj