Experimental: show weekly downloads sparkline chart #8242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
approved these changes
Nov 7, 2024
jonasfj
approved these changes
Nov 7, 2024
szakarias
force-pushed
the
weeklySparklineChart
branch
from
6ff065d to
79c0caf
Compare
szakarias
force-pushed
the
weeklySparklineChart
branch
from
79c0caf to
f831baf
Compare
sigurdm
reviewed
Nov 14, 2024
|
|
||
| .weekly-sparkline-area { | ||
| fill: var(--pub-weekly-chart-main-color); | ||
| opacity: 0.3; |
Contributor
There was a problem hiding this comment.
This can be simulated without transparency https://stackoverflow.com/questions/58227072/how-do-you-simulate-the-opacity-effect-on-an-element-without-making-it-transpare
Suggested change
| opacity: 0.3; | |
| filter: contrast(calc(0.3 /(2 - 0.3))) brightness(calc(2 - 0.3)); |
| .weekly-sparkline-area { | ||
| fill: var(--pub-weekly-chart-main-color); | ||
| opacity: 0.3; | ||
| stroke-width: 0; |
Contributor
There was a problem hiding this comment.
Suggested change
| stroke-width: 0; | |
| stroke-width: 2; | |
| stroke: var(--pub-weekly-chart-main-color); |
This would get rid of the funkyness at the bottom here:
You would though also have to insert the .weekly-sparkline-area into the svg before the .weekly-sparkline-line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.