Skip to content

Increase description weight from 0.9 to 1.0 #8246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Increase description weight from 0.9 to 1.0 #8246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ Important changes to data models, configuration, and migrations between each
AppEngine version, listed here to ease deployment and troubleshooting.

## Next Release (replace with git tag when deployed)
* Note: `search` increased `description` weight from `0.9` to `1.0`.

## `20241107t132800-all`
* `search` uses the `IndexedScore` to reduce memory allocations.
Expand Down
2 changes: 1 addition & 1 deletion app/lib/search/mem_index.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ class InMemoryPackageIndex {

final wordScore =
_packageNameIndex.searchWord(word, filterOnNonZeros: packageScores);
_descrIndex.searchAndAccumulate(word, weight: 0.90, score: wordScore);
_descrIndex.searchAndAccumulate(word, score: wordScore);
_readmeIndex.searchAndAccumulate(word, weight: 0.75, score: wordScore);
packageScores.multiplyAllFrom(wordScore);
}
Expand Down
2 changes: 1 addition & 1 deletion app/test/search/bluetooth_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ void main() {
'packageHits': [
{
'package': 'flutter_blue',
'score': closeTo(0.89, 0.01),
'score': closeTo(0.98, 0.01),
},
],
});
Expand Down
2 changes: 1 addition & 1 deletion app/test/search/in_app_payments_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Add _In-App Payments_ to your Flutter app with this plugin.''')),
'packageHits': [
{
'package': 'flutter_iap',
'score': closeTo(0.57, 0.01),
'score': closeTo(0.70, 0.01),
},
],
});
Expand Down
2 changes: 1 addition & 1 deletion app/test/search/json_tool_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ void main() {
'sdkLibraryHits': [],
'packageHits': [
{'package': 'jsontool', 'score': 1.0},
{'package': 'json2entity', 'score': closeTo(0.87, 0.01)},
{'package': 'json2entity', 'score': closeTo(0.97, 0.01)},
{'package': 'json_to_model', 'score': closeTo(0.73, 0.01)},
],
});
Expand Down
26 changes: 13 additions & 13 deletions app/test/search/mem_index_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
'packageHits': [
{
'package': 'http',
'score': closeTo(0.85, 0.01),
'score': closeTo(0.93, 0.01),
},
],
});
Expand Down Expand Up @@ -140,7 +140,7 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
'sdkLibraryHits': [],
'packageHits': [
{'package': 'http', 'score': closeTo(0.69, 0.01)},
{'package': 'async', 'score': closeTo(0.57, 0.01)},
{'package': 'async', 'score': closeTo(0.63, 0.01)},
],
});
});
Expand Down Expand Up @@ -381,7 +381,7 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
'totalCount': 1,
'sdkLibraryHits': [],
'packageHits': [
{'package': 'http', 'score': closeTo(0.85, 0.01)},
{'package': 'http', 'score': closeTo(0.93, 0.01)},
],
});
});
Expand Down Expand Up @@ -494,7 +494,7 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
'totalCount': 1,
'sdkLibraryHits': [],
'packageHits': [
{'package': 'http', 'score': closeTo(0.87, 0.01)},
{'package': 'http', 'score': closeTo(0.98, 0.01)},
],
});

Expand All @@ -505,8 +505,8 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
'totalCount': 3,
'sdkLibraryHits': [],
'packageHits': [
{'package': 'chrome_net', 'score': closeTo(0.88, 0.01)},
{'package': 'async', 'score': closeTo(0.88, 0.01)},
{'package': 'chrome_net', 'score': closeTo(0.98, 0.01)},
{'package': 'async', 'score': closeTo(0.98, 0.01)},
{'package': 'http', 'score': closeTo(0.72, 0.01)},
],
});
Expand All @@ -520,7 +520,7 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
'totalCount': 1,
'sdkLibraryHits': [],
'packageHits': [
{'package': 'http', 'score': closeTo(0.63, 0.01)},
{'package': 'http', 'score': closeTo(0.70, 0.01)},
],
});
});
Expand Down Expand Up @@ -615,8 +615,8 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
'totalCount': 2,
'sdkLibraryHits': [],
'packageHits': [
{'package': 'def', 'score': closeTo(0.69, 0.01)},
{'package': 'abc', 'score': closeTo(0.42, 0.01)},
{'package': 'def', 'score': closeTo(0.77, 0.01)},
{'package': 'abc', 'score': closeTo(0.47, 0.01)},
]
},
);
Expand All @@ -629,7 +629,7 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
'sdkLibraryHits': [],
'packageHits': [
// `abc` is at its natural place
{'package': 'def', 'score': closeTo(0.69, 0.01)},
{'package': 'def', 'score': closeTo(0.77, 0.01)},
{'package': 'abc', 'score': closeTo(0.48, 0.01)},
]
});
Expand All @@ -644,7 +644,7 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
'sdkLibraryHits': [],
'packageHits': [
// `abc` is at its natural place
{'package': 'def', 'score': closeTo(0.69, 0.01)},
{'package': 'def', 'score': closeTo(0.77, 0.01)},
{'package': 'abc', 'score': closeTo(0.48, 0.01)},
]
});
Expand All @@ -659,7 +659,7 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
'sdkLibraryHits': [],
'packageHits': [
// `abc` is not present in the package list
{'package': 'def', 'score': closeTo(0.69, 0.01)},
{'package': 'def', 'score': closeTo(0.77, 0.01)},
]
});
});
Expand Down Expand Up @@ -690,7 +690,7 @@ server.dart adds a small, prescriptive server (PicoServer) that can be configure
'sdkLibraryHits': [],
'packageHits': [
{'package': 'flutter_modular', 'score': 1.0},
{'package': 'serveme', 'score': closeTo(0.87, 0.01)},
{'package': 'serveme', 'score': closeTo(0.97, 0.01)},
]
},
);
Expand Down
2 changes: 1 addition & 1 deletion app/test/search/rest_api_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Recent versions (0.3.x and 0.4.x) of this plugin require [extensible codec funct
'packageHits': [
{
'package': 'currency_cloud',
'score': closeTo(0.77, 0.01),
'score': closeTo(0.95, 0.01),
},
{
'package': 'cloud_firestore', // finds `rest` in name
Expand Down
Loading