Skip to content

Increase concurrency and handle errors better #8257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Increase concurrency and handle errors better #8257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
025b4e2
Increase concurrency and handle errors better
jonasfj Nov 8, 2024
286bd4e
Update app/lib/package/api_export/api_exporter.dart
jonasfj Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion app/lib/package/api_export/api_exporter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ void registerApiExporter(ApiExporter value) =>
/// The active API Exporter service or null if it hasn't been initialized.
ApiExporter? get apiExporter => ss.lookup(#_apiExporter) as ApiExporter?;

const _concurrency = 30;
const _concurrency = 50;

class ApiExporter {
final ExportedApi _api;
Expand Down Expand Up @@ -134,6 +134,7 @@ class ApiExporter {
Future<void> synchronizeExportedApi() async {
final allPackageNames = <String>{};
final packageQuery = dbService.query<Package>();
var errCount = 0;
await packageQuery.run().parallelForEach(_concurrency, (pkg) async {
final name = pkg.name!;
if (pkg.isNotVisible) {
Expand All @@ -143,6 +144,9 @@ class ApiExporter {

// TODO: Consider retries around all this logic
await synchronizePackage(name);
}, onError: (e, st) {
_log.warning('synchronizePackage() failed', e, st);
errCount++;
});

await synchronizePackageNameCompletionData();
Expand All @@ -157,6 +161,12 @@ class ApiExporter {
});

await _api.garbageCollect(allPackageNames);

if (errCount > 0) {
throw Exception(
'$errCount exceptions happened while calling synchronizeExportedApi',
);
}
}

/// Sync package and into [ExportedApi], this will synchronize package into
Expand Down
2 changes: 1 addition & 1 deletion app/lib/package/api_export/exported_api.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const _minGarbageAge = Duration(hours: 3);
/// All writes to the bucket containing the exported API should go through this
/// interface.
final class ExportedApi {
final Pool _pool = Pool(50);
final Pool _pool = Pool(80);
final Storage _storage;
final Bucket _bucket;
final List<String> _prefixes = [
Expand Down
Loading