Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Nov 25, 2024

This is a temporary override to get package:analyzer documentation generated.

@sigurdm
Copy link
Contributor

sigurdm commented Nov 25, 2024

Could you do something along the lines of dart pub deps --json | jq '.packages.[]|select(.name=="_macros")' to also catch transitive dependency on package _macros ?

@isoos
Copy link
Collaborator Author

isoos commented Nov 25, 2024

Could you do something along the lines of dart pub deps --json | jq '.packages.[]|select(.name=="_macros")' to also catch transitive dependency on package _macros?

At the moment I would keep this simple, mostly because if the package has a transient macros dependency, we will use the stable SDK and it will fail regardless. And we can't use the dart pub deps with the current SDK detection mechanism yet, as it wouldn't resolve the dependencies on the stable SDK.

@isoos
Copy link
Collaborator Author

isoos commented Nov 26, 2024

I think this + #8339 is a good baseline, pushing these to staging right now. We still need to implement the new redirect from -library.html to the directory-root, and also update some test assumptions, and we seem to provide a reasonable documentation page for these packages.

@isoos isoos force-pushed the dartdoc-override branch 2 times, most recently from 7e444f4 to 94b2003 Compare December 2, 2024 16:41
@isoos isoos merged commit bd8f7ed into dart-lang:master Dec 3, 2024
32 checks passed
@isoos isoos deleted the dartdoc-override branch December 3, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants