Skip to content

Reduce complexity of 'normalizeBeforeIndexing' method. #8371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Reduce complexity of 'normalizeBeforeIndexing' method. #8371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions app/lib/search/text_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import '../shared/markdown.dart';
final _separatorChars = '_.?!,;:=()<>[]{}~@#\$%&|+-*\\/"\'`';
final _escapedSeparators = _separatorChars.split('').map((s) => '\\$s').join();
final _separators = RegExp('[$_escapedSeparators]|\\s');
final RegExp _nonCharacterRegExp = RegExp('[^a-z0-9]');
final _nonCharactersRegExp = RegExp('[^a-z0-9]+');
final RegExp _multiWhitespaceRegExp = RegExp('\\s+');
final RegExp _exactTermRegExp = RegExp(r'"([^"]+)"');

Expand Down Expand Up @@ -58,12 +58,7 @@ String compactReadme(String? text) {

String normalizeBeforeIndexing(String? text) {
if (text == null) return '';
final String t = text
.toLowerCase()
.replaceAll(_nonCharacterRegExp, ' ')
.replaceAll(_multiWhitespaceRegExp, ' ')
.trim();
return t;
return text.toLowerCase().replaceAll(_nonCharactersRegExp, ' ').trim();
}

Iterable<String> splitForIndexing(String? text) {
Expand Down
Loading