Skip to content

Log isolate renewals. #8372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Log isolate renewals. #8372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/lib/service/entrypoint/_isolate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ class IsolateRunner {
required Duration wait,
}) async {
final isolatesToClose = [..._isolates];
final lastId = isolatesToClose.isEmpty ? null : isolatesToClose.last.id;
logger.info('About to renew $count isolate(s) '
'(closing ${isolatesToClose.length}, last: `$lastId`).');

await start(count);
// prevent traffic to hit the old instances
Expand All @@ -75,6 +78,8 @@ class IsolateRunner {
for (final i in isolatesToClose) {
await i.close();
}
logger.info('Renewed $count isolate(s) '
'(closing ${isolatesToClose.length}, last: `$lastId`).');
}

/// Send [RequestMessage] and wait for [ReplyMessage] returning
Expand Down
Loading