Skip to content

Remove <p> tag from weekly sparkline #8392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Remove <p> tag from weekly sparkline #8392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/lib/frontend/templates/views/pkg/info_box.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ d.Node packageInfoBoxNode({
_publisher(package.publisherId),
if (data.weeklyDownloadCounts != null &&
requestContext.experimentalFlags.showDownloadCounts)
_block('Weekly Downloads', _downloadsChart(data.weeklyDownloadCounts!)),
_downloadsChart(data.weeklyDownloadCounts!),
_metadata(
description: version.pubspec!.description,
metaLinks: metaLinks,
Expand Down Expand Up @@ -120,7 +120,11 @@ d.Node _downloadsChart(WeeklyDownloadCounts wdc) {
'data-weekly-sparkline-points':
_encodeForWeeklySparkline(wdc.weeklyDownloads, wdc.newestDate),
});
return container;

return d.fragment([
d.h3(classes: ['title'], text: 'Weekly Downloads'),
container,
]);
}

String _encodeForWeeklySparkline(List<int> downloads, DateTime newestDate) {
Expand Down
24 changes: 14 additions & 10 deletions app/test/frontend/golden/pkg_activity_log_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,18 +370,20 @@ <h3 class="detail-lead-title">Metadata</h3>
</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
<h3 class="title">Publisher</h3>
<p>
<span>unverified uploader</span>
</p>
<h3 class="title">Weekly Downloads</h3>
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
<h3 class="title pkg-infobox-metadata">Metadata</h3>
<p>oxygen is awesome</p>
<p>
Expand Down Expand Up @@ -446,18 +448,20 @@ <h3 class="detail-metadata-title">
</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
<h3 class="title">Publisher</h3>
<p>
<span>unverified uploader</span>
</p>
<h3 class="title">Weekly Downloads</h3>
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
<h3 class="title pkg-infobox-metadata">Metadata</h3>
<p>oxygen is awesome</p>
<p>
Expand Down
24 changes: 14 additions & 10 deletions app/test/frontend/golden/pkg_admin_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,18 +655,20 @@ <h3>Restore retracted package version</h3>
</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
<h3 class="title">Publisher</h3>
<p>
<span>unverified uploader</span>
</p>
<h3 class="title">Weekly Downloads</h3>
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
<h3 class="title pkg-infobox-metadata">Metadata</h3>
<p>oxygen is awesome</p>
<p>
Expand Down Expand Up @@ -731,18 +733,20 @@ <h3 class="detail-metadata-title">
</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
<h3 class="title">Publisher</h3>
<p>
<span>unverified uploader</span>
</p>
<h3 class="title">Weekly Downloads</h3>
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
<h3 class="title pkg-infobox-metadata">Metadata</h3>
<p>oxygen is awesome</p>
<p>
Expand Down
24 changes: 14 additions & 10 deletions app/test/frontend/golden/pkg_changelog_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,18 +240,20 @@ <h2 class="changelog-version hash-header" id="120">
</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
<h3 class="title">Publisher</h3>
<p>
<span>unverified uploader</span>
</p>
<h3 class="title">Weekly Downloads</h3>
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
<h3 class="title pkg-infobox-metadata">Metadata</h3>
<p>oxygen is awesome</p>
<p>
Expand Down Expand Up @@ -317,18 +319,20 @@ <h3 class="detail-metadata-title">
</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
<h3 class="title">Publisher</h3>
<p>
<span>unverified uploader</span>
</p>
<h3 class="title">Weekly Downloads</h3>
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
<h3 class="title pkg-infobox-metadata">Metadata</h3>
<p>oxygen is awesome</p>
<p>
Expand Down
24 changes: 14 additions & 10 deletions app/test/frontend/golden/pkg_example_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,18 +237,20 @@ <h3 class="detail-lead-title">Metadata</h3>
</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
<h3 class="title">Publisher</h3>
<p>
<span>unverified uploader</span>
</p>
<h3 class="title">Weekly Downloads</h3>
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
<h3 class="title pkg-infobox-metadata">Metadata</h3>
<p>oxygen is awesome</p>
<p>
Expand Down Expand Up @@ -314,18 +316,20 @@ <h3 class="detail-metadata-title">
</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
<h3 class="title">Publisher</h3>
<p>
<span>unverified uploader</span>
</p>
<h3 class="title">Weekly Downloads</h3>
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
<h3 class="title pkg-infobox-metadata">Metadata</h3>
<p>oxygen is awesome</p>
<p>
Expand Down
24 changes: 14 additions & 10 deletions app/test/frontend/golden/pkg_install_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,18 +263,20 @@ <h3>Import it</h3>
</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
<h3 class="title">Publisher</h3>
<p>
<span>unverified uploader</span>
</p>
<h3 class="title">Weekly Downloads</h3>
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
<h3 class="title pkg-infobox-metadata">Metadata</h3>
<p>oxygen is awesome</p>
<p>
Expand Down Expand Up @@ -340,18 +342,20 @@ <h3 class="detail-metadata-title">
</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
<h3 class="title">Publisher</h3>
<p>
<span>unverified uploader</span>
</p>
<h3 class="title">Weekly Downloads</h3>
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
<h3 class="title pkg-infobox-metadata">Metadata</h3>
<p>oxygen is awesome</p>
<p>
Expand Down
Loading
Loading