Skip to content

Disallow email with commas. #8404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Disallow email with commas. #8404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/lib/service/email/email_templates.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ bool isValidEmail(String email) {
// strict pattern check
if (!_strictEmailRegExp.hasMatch(email)) return false;

// also reject commas
if (email.contains(',')) return false;

// checking for IPv4 or IPv6 addresses
var isInternetAddress = false;
try {
Expand Down
4 changes: 4 additions & 0 deletions app/test/service/email/email_templates_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ void main() {
// verify that we have rejected emails
expect(rejectedEmails, hasLength(215));
});

test('reject multiple addresses', () {
expect(isValidEmail('abc@example.com,efg@example.com'), false);
});
});

group('EmailAddress format', () {
Expand Down
Loading