Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Jan 6, 2025

@isoos isoos requested a review from sigurdm January 6, 2025 15:25
@isoos isoos force-pushed the search-popularity branch from 6f90185 to 729e929 Compare January 6, 2025 15:32
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could forward the old popularity searches to search ranked by download counts if we want to preserve old links.

Alternatively they could go to the generic ranking.

@isoos
Copy link
Collaborator Author

isoos commented Jan 7, 2025

I guess we could forward the old popularity searches to search ranked by download counts if we want to preserve old links.

If you do https://pub.dev/packages?sort=x it will use the default sort order. So maybe what we need here is to canonicalize the search URLs and when we get a non-canonical one, we redirect to it. We already have parts of the redirect in place, maybe we just need to extend it.

@isoos isoos merged commit 33ee8c8 into dart-lang:master Jan 7, 2025
32 checks passed
@isoos isoos deleted the search-popularity branch January 7, 2025 08:26
@sigurdm
Copy link
Contributor

sigurdm commented Jan 7, 2025

If you do https://pub.dev/packages?sort=x it will use the default sort order.

I think that is good enough. Let's just remove the popularity one then. Old links would still lead to some search result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants