Skip to content

Remove fallback URL resolver. #8454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

Remove fallback URL resolver. #8454

merged 1 commit into from
Jan 10, 2025

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Jan 10, 2025

  • Removes the fallback URL resolver that used the unverified links to resolve relative references.
  • Relative links are only resolved when a repository has been verified (and verification did not fail).
  • This change also fixed a few test cases, now that it uses the pana's url resolver all the time.

@isoos isoos requested a review from sigurdm January 10, 2025 16:16
@isoos isoos merged commit c4bea03 into dart-lang:master Jan 10, 2025
32 checks passed
@isoos isoos deleted the fallback-url-resolver branch January 10, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isoos @sigurdm