Skip to content

Updated link colors to increase contrasts #8479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Updated link colors to increase contrasts #8479

merged 1 commit into from
Jan 21, 2025

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Jan 21, 2025

Follow-ups to Lighthouse low contrast reports:

  • The light theme's link color is now switched to dart.dev's choice of color (gets a bit darker).
  • The dark theme's link color, and also the default background become less vibrant.

Light mode before/after:
image
image

Dark mode before/after:
image
image

@isoos isoos requested review from jonasfj and sigurdm January 21, 2025 10:48
@isoos isoos changed the title Updated color contrasts Updated link colors to increase contrasts Jan 21, 2025
@isoos isoos merged commit 5027967 into dart-lang:master Jan 21, 2025
31 checks passed
@isoos isoos deleted the color-contrasts branch January 21, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isoos @sigurdm