Skip to content

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 24, 2025

  • Opacity change on hover may not be a good idea #8493
  • Note: filter: brightness() did not work for me on images, but maybe other factors are at play.
  • I'm not yet sure how to resolve the same opacity issue in light mode, given we are using it the current way for a long time, and also the brightness issue above, so I'm limiting this change to dark mode for now, as it seems to be an improvement there.

@isoos isoos requested review from jonasfj and sigurdm January 24, 2025 16:46
@isoos
Copy link
Collaborator Author

isoos commented Jan 24, 2025

I've started a staging push with this, so that we can take a look at it at least in dark mode, and let's discuss how we should try to solve it for images too.

/cc @parlough


a {
&:hover {
opacity: 1.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have opacity other than 1?

Copy link
Collaborator Author

@isoos isoos Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the version tab icons have it on 0.7 by default (but uneffected as they are on the element). However, in this case this is to counter the main rule here:
https://github.com/dart-lang/pub-dev/blob/master/pkg/web_css/lib/src/_base.scss#L98-L100

I shall move that out to a separate light-theme/dark-theme styles so we don't need the override.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, PTAL.

@isoos isoos merged commit 7fc9704 into dart-lang:master Jan 29, 2025
31 checks passed
@isoos isoos deleted the brighness branch January 29, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants