Skip to content

Updated retry handling in storage access. #8499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

Updated retry handling in storage access. #8499

merged 1 commit into from
Jan 28, 2025

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Jan 27, 2025

  • removing retryAsync from utils.dart
  • consolidating retry logic into the single _retry wrapper inside storage.dart
  • renamed tryDelete -> tryDeleteWithRetry so that the name does reflect on the retry operation
  • removed deleteFromBucket, using Bucket.tryDeleteWithRetry instead

@isoos isoos requested review from jonasfj and sigurdm January 27, 2025 16:08
@isoos isoos merged commit c04e483 into dart-lang:master Jan 28, 2025
31 checks passed
@isoos isoos deleted the retry-storage branch January 28, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isoos @sigurdm