Skip to content

Fix aborted token handling in task scheduler. #8511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

Fix aborted token handling in task scheduler. #8511

merged 1 commit into from
Jan 31, 2025

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Jan 30, 2025

  • Fixes Task race condition #8503
  • Apparently we filtered the already expired tokens twice, only the second time we filtered the non-expired tokens, in effect, we never really stored any aborted tokens.
  • Added test to check for the correct behavior (with the API exception code).

@isoos isoos requested review from jonasfj and sigurdm January 30, 2025 16:11
@isoos isoos merged commit a3ef662 into dart-lang:master Jan 31, 2025
31 checks passed
@isoos isoos deleted the fix-tasks branch January 31, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Task race condition

2 participants

@isoos @sigurdm