-
Notifications
You must be signed in to change notification settings - Fork 166
Tab redesign: removing icon, orange text in dark mode. #8533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cc @parlough |
|
Note: available on staging. |
| (t) => d.li( | ||
| classes: t.titleClasses, | ||
| attributes: { | ||
| if (t.isPrivate) 'title': 'For authorized users only.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is slightly misleading.
I would like the tooltip to reflect the tab title, not the reason for the different color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have some examples in mind for that different text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have a title text for each tab:
Something along the lines of:
Readme: "Description of the package"
Changelog: "Describes changes between versions"
Example: "An example of how to use this package"
Installing: "How to use this package in your own project"
Versions: "All published versions of this package"
Scores: "Automated analysis and download metrics"
Admin: "Admin settings for this package - only for admins of this package"
Activity log: "Historical admin and publication events - only for admins of this package"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I was not more clear, but I don't think it should block the landing of this PR. I can live with the titles as they are.
sigurdm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how this looks!
|
I think I'll land this, and add new descriptions as suggested above in a follow-up PR. |
my-<page>links vs/adminnew screens:
--
--
--