Skip to content

Enable experiments #8551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Enable experiments #8551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions app/lib/frontend/handlers/experimental.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,13 @@ class ExperimentalFlags {
return params;
}

bool get isSearchCompletionEnabled => isEnabled('search-completion');
bool get isSearchCompletionEnabled => true;
bool get isSearchTopicsEnabled => isEnabled('search-topics');

bool get isDarkModeEnabled => isEnabled('dark');
bool get isDarkModeEnabled => true;
bool get isDarkModeDefault => isEnabled('dark-as-default');

bool get showDownloadCountsVersionChart =>
isEnabled('download-counts-version-chart');
bool get showDownloadCountsVersionChart => true;

String encodedAsCookie() => _enabled.join(':');

Expand Down
2 changes: 0 additions & 2 deletions app/lib/frontend/templates/views/shared/layout.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,6 @@ d.Node pageLayoutNode({
'body',
classes: [
...?bodyClasses,
if (requestContext.experimentalFlags.isDarkModeEnabled)
'-experimental-dark-mode',
requestContext.experimentalFlags.isDarkModeDefault
? 'dark-theme'
: 'light-theme',
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/authorized_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/consent_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/create_publisher_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/error_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,13 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<div class="_banner-bg">
<div class="container">
<form class="search-bar banner-item" action="/packages" autocomplete="off">
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-widget="completion" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<span class="icon"></span>
</form>
</div>
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/help_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/landing_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,15 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<div class="_banner-bg">
<div class="container home-banner">
<h2 class="_visuallyhidden">pub.dev package manager</h2>
<img class="logo" src="/static/hash-%%etag%%/img/pub-dev-logo.svg" alt="" width="328" height="70" role="presentation"/>
<form class="search-bar banner-item" action="/packages" autocomplete="off">
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-widget="completion" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<span class="icon"></span>
</form>
<p class="text">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/my_activity_log_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="-wide-header-detail-page">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/my_liked_packages.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="-wide-header-detail-page">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/my_packages.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="-wide-header-detail-page">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/my_publishers.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="-wide-header-detail-page">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_activity_log_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_admin_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_changelog_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_example_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/pkg_index_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,13 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<div class="_banner-bg">
<div class="container">
<form class="search-bar banner-item" action="/packages" autocomplete="off">
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" value="sdk:dart" title="Search" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" value="sdk:dart" title="Search" data-widget="completion" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<span class="icon"></span>
<div class="search-filters-btn-wrapper -active">
<img class="search-filters-btn search-filters-btn-inactive" src="/static/hash-%%etag%%/img/search-filters-inactive.svg" alt="toggle the display of search filters (inactive)" width="42" height="42"/>
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_install_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
23 changes: 23 additions & 0 deletions app/test/frontend/golden/pkg_score_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down Expand Up @@ -305,6 +306,28 @@ <h3>
<a href="/packages/oxygen/score/log.txt">analysis log</a>
for details.
</p>
<h1>Weekly downloads</h1>
<div class="downloads-chart-display-modes">
<div class="mdc-form-field">
<strong>Display as:</strong>
<input id="display-modes-unstacked" class="downloads-chart-radio-button" type="radio" name="display-modes" value="unstacked" checked=""/>
<label for="display-modes-unstacked">Unstacked</label>
<input id="version-modes-stacked" class="downloads-chart-radio-button" type="radio" name="display-modes" value="stacked"/>
<label for="version-modes-stacked">Stacked</label>
</div>
</div>
<div class="downloads-chart-version-modes">
<div class="mdc-form-field">
<strong>By versions:</strong>
<input id="version-modes-major" class="downloads-chart-radio-button" type="radio" name="version-modes" value="major" checked=""/>
<label for="version-modes-major">Major</label>
<input id="version-modes-minor" class="downloads-chart-radio-button" type="radio" name="version-modes" value="minor"/>
<label for="version-modes-minor">Minor</label>
<input id="version-modes-patch" class="downloads-chart-radio-button" type="radio" name="version-modes" value="patch"/>
<label for="version-modes-patch">Patch</label>
</div>
</div>
<div id="-downloads-chart" class="downloads-chart" data-widget="downloads-chart" data-downloads-chart-points="%%downloads-chart-points%%" data-downloads-chart-versions-radio="version-modes" data-downloads-chart-display-radio="display-modes"></div>
</section>
</div>
</div>
Expand Down
23 changes: 23 additions & 0 deletions app/test/frontend/golden/pkg_score_page_with_downloads_chart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down Expand Up @@ -305,6 +306,28 @@ <h3>
<a href="/packages/oxygen/score/log.txt">analysis log</a>
for details.
</p>
<h1>Weekly downloads</h1>
<div class="downloads-chart-display-modes">
<div class="mdc-form-field">
<strong>Display as:</strong>
<input id="display-modes-unstacked" class="downloads-chart-radio-button" type="radio" name="display-modes" value="unstacked" checked=""/>
<label for="display-modes-unstacked">Unstacked</label>
<input id="version-modes-stacked" class="downloads-chart-radio-button" type="radio" name="display-modes" value="stacked"/>
<label for="version-modes-stacked">Stacked</label>
</div>
</div>
<div class="downloads-chart-version-modes">
<div class="mdc-form-field">
<strong>By versions:</strong>
<input id="version-modes-major" class="downloads-chart-radio-button" type="radio" name="version-modes" value="major" checked=""/>
<label for="version-modes-major">Major</label>
<input id="version-modes-minor" class="downloads-chart-radio-button" type="radio" name="version-modes" value="minor"/>
<label for="version-modes-minor">Minor</label>
<input id="version-modes-patch" class="downloads-chart-radio-button" type="radio" name="version-modes" value="patch"/>
<label for="version-modes-patch">Patch</label>
</div>
</div>
<div id="-downloads-chart" class="downloads-chart" data-widget="downloads-chart" data-downloads-chart-points="%%downloads-chart-points%%" data-downloads-chart-versions-radio="version-modes" data-downloads-chart-display-radio="display-modes"></div>
</section>
</div>
</div>
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_show_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_show_page_discontinued.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_show_page_flutter_plugin.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_show_page_publisher.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_show_page_retracted.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_show_version_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/pkg_versions_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/publisher_activity_log_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,13 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<div class="_banner-bg">
<div class="container">
<form class="search-bar banner-item" action="/packages" autocomplete="off">
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" value="publisher:example.com" title="Search" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" value="publisher:example.com" title="Search" data-widget="completion" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<span class="icon"></span>
</form>
</div>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/publisher_admin_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,13 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<div class="_banner-bg">
<div class="container">
<form class="search-bar banner-item" action="/packages" autocomplete="off">
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" value="publisher:example.com" title="Search" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" value="publisher:example.com" title="Search" data-widget="completion" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<span class="icon"></span>
</form>
</div>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/publisher_list_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,13 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<div class="_banner-bg">
<div class="container">
<form class="search-bar banner-item" action="/packages" autocomplete="off">
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-widget="completion" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<span class="icon"></span>
<div class="search-filters-btn-wrapper">
<img class="search-filters-btn search-filters-btn-inactive" src="/static/hash-%%etag%%/img/search-filters-inactive.svg" alt="toggle the display of search filters (inactive)" width="42" height="42"/>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/publisher_packages_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,13 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<div class="_banner-bg">
<div class="container">
<form class="search-bar banner-item" action="/packages" autocomplete="off">
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-widget="completion" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<span class="icon"></span>
</form>
</div>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/publisher_unlisted_packages_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,13 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<div class="_banner-bg">
<div class="container">
<form class="search-bar banner-item" action="/packages" autocomplete="off">
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-widget="completion" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
<span class="icon"></span>
</form>
</div>
Expand Down
1 change: 1 addition & 0 deletions app/test/frontend/golden/report_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ <h3 class="foldable-button">
</div>
</div>
</nav>
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
</div>
<div id="banner-container"></div>
<main class="container">
Expand Down
Loading
Loading