Skip to content

Downloads chart: fix placement of cursor #8574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Downloads chart: fix placement of cursor #8574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pkg/web_app/lib/src/widget/downloads_chart/widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ void drawChart(
}

final chart = SVGGElement();
svg.replaceChildren(chart);
svg.append(chart);

// Axis and ticks

Expand Down Expand Up @@ -449,7 +449,7 @@ void drawChart(
hideCursor(1);

svg.onMouseMove.listen((e) {
final boundingRect = chart.getBoundingClientRect();
final boundingRect = svg.getBoundingClientRect();
if (e.x < boundingRect.x + xZero ||
e.x > boundingRect.x + xMax ||
e.y < boundingRect.y + yMax ||
Expand All @@ -465,10 +465,8 @@ void drawChart(
'top:${e.y + toolTipOffsetFromMouse + document.scrollingElement!.scrollTop}px;'
'left:${e.x}px;');

final pointPercentage =
(e.x - chart.getBoundingClientRect().x - xZero) / chartWidth;
final pointPercentage = (e.x - boundingRect.x - xZero) / chartWidth;
final nearestIndex = ((values.length - 1) * pointPercentage).round();

final selectedDay =
computeDateForWeekNumber(newestDate, values.length, nearestIndex);
if (selectedDay == lastSelectedDay) return;
Expand Down Expand Up @@ -497,7 +495,7 @@ void drawChart(
..append(rangeText);

final suffix = (displayMode == DisplayMode.percentage)
? '(${(downloads[rangeIndex] * 100 / totals[nearestIndex]).toStringAsPrecision(2)}%)'
? ' (${(downloads[rangeIndex] * 100 / totals[nearestIndex]).toStringAsPrecision(2)}%)'
: '';
final text =
'${formatWithThousandSeperators(downloads[rangeIndex])}$suffix';
Expand Down
Loading