Built files are not built, only asserted when the app starts in a container. #8680
Conversation
Dockerfile.app
Outdated
| ENV PUB_CACHE="/project/.pub-cache" | ||
| # Let the pub server know that it is running inside a container. | ||
| # It will not rebuild web-app assets, only assert their presence. | ||
| ENV PUB_DEV_IN_CONTAINER="1" |
There was a problem hiding this comment.
| ENV PUB_DEV_IN_CONTAINER="1" | |
| ENV PUB_DEV_ENVIRONMENT="production" |
I think that's a better indicator, or even just ENVIRONMENT=production.
app/lib/frontend/static_files.dart
Outdated
| Future<void> assertExists(String path) async { | ||
| final file = File(path); | ||
| if (!file.existsSync()) { | ||
| throw AssertionError('`$path`` is missing.'); |
There was a problem hiding this comment.
Will this prevent startup?
We could opt to make the build fail, if they are not present, and just serve empty file or 404s if they are requested and not present.
Along with shouting in logs at startup, on the other hand crashing when not present is very reliable :D
There was a problem hiding this comment.
It will throw in the HTTP frontend isolate, before the HTTP server is up and with that AppEngine will surely kill it. Though, you are right, it may not be a good idea, instead, we should serve 404 + shout in the logs. The current way this is is implemented will look like the build succeeded, but serving will never happen. I'll redo this.
|
Closing in favor of #8729 |
3 participants
Fixes #8673.