Skip to content

Slightly lower score for depluralized matches. #8692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Slightly lower score for depluralized matches. #8692

wants to merge 1 commit into from

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Apr 2, 2025

#8688

  • fixes the oversight that the substring check should be done on the lowercased value.
  • does not really solve the de-pluralization problem space, but slightly reduces the miss-attribution ranks

@isoos isoos requested review from jonasfj and sigurdm April 2, 2025 08:41
@isoos isoos mentioned this pull request Apr 3, 2025
Merged
@isoos
Copy link
Collaborator Author

isoos commented Apr 3, 2025

Closing as we've decided to remove the depluralization code instead. #8696

@isoos isoos closed this Apr 3, 2025
@isoos isoos deleted the search-depluralized branch April 3, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasfj jonasfj Awaiting requested review from jonasfj

@sigurdm sigurdm Awaiting requested review from sigurdm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@isoos