Skip to content

Always use the new POST method for accessing search service. #8953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

Always use the new POST method for accessing search service. #8953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 32 additions & 43 deletions app/lib/search/search_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,11 @@ class SearchClient {
if (hasLikedByMeTag) {
skipCache = true;
}
final useLikedByMe =
hasLikedByMeTag && requestContext.experimentalFlags.useMyLikedSearch;

List<String>? packages;
if (userId != null && hasLikedByMeTag) {
if (userId != null && useLikedByMe) {
final likedPackages = await likeBackend.listPackageLikes(userId);
packages = likedPackages.map((l) => l.package!).toList();
}
Expand All @@ -88,53 +90,40 @@ class SearchClient {
}) async {
final httpHostPort = prefix ?? activeConfiguration.searchServicePrefix;
try {
if (requestContext.experimentalFlags.useMyLikedSearch) {
return await withRetryHttpClient(
(client) async {
var data = query.toSearchRequestData();
if (userId != null && hasLikedByMeTag) {
final newQuery = data.query
?.replaceAll(AccountTag.isLikedByMe, ' ')
.trim();
final newTags = data.tags!
.where((e) => e != AccountTag.isLikedByMe)
.toList();
data = data.replace(
query: newQuery,
tags: newTags,
packages: packages,
);
}
// NOTE: Keeping the query parameter to help investigating logs.
final uri = Uri.parse(
'$httpHostPort/search',
).replace(queryParameters: {'q': data.query});
final rs = await client.post(
uri,
headers: {
...?cloudTraceHeaders(),
'content-type': 'application/json',
},
body: json.encode(data.toJson()),
return await withRetryHttpClient(
(client) async {
var data = query.toSearchRequestData();
if (userId != null && useLikedByMe) {
final newQuery = data.query
?.replaceAll(AccountTag.isLikedByMe, ' ')
.trim();
final newTags = data.tags!
.where((e) => e != AccountTag.isLikedByMe)
.toList();
data = data.replace(
query: newQuery,
tags: newTags,
packages: packages,
);
return (statusCode: rs.statusCode, body: rs.body);
},
client: _httpClient,
retryIf: (e) =>
(e is UnexpectedStatusException &&
e.statusCode == searchIndexNotReadyCode),
);
}
final serviceUrl = '$httpHostPort/search$serviceUrlParams';
return await httpGetWithRetry(
Uri.parse(serviceUrl),
}
// NOTE: Keeping the query parameter to help investigating logs.
final uri = Uri.parse(
'$httpHostPort/search',
).replace(queryParameters: {'q': data.query});
final rs = await client.post(
uri,
headers: {
...?cloudTraceHeaders(),
'content-type': 'application/json',
},
body: json.encode(data.toJson()),
);
return (statusCode: rs.statusCode, body: rs.body);
},
client: _httpClient,
headers: cloudTraceHeaders(),
perRequestTimeout: Duration(seconds: 5),
retryIf: (e) =>
(e is UnexpectedStatusException &&
e.statusCode == searchIndexNotReadyCode),
responseFn: (rs) => (statusCode: rs.statusCode, body: rs.body),
);
} on TimeoutException {
return null;
Expand Down