Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Nov 20, 2025

  • Needed for the SQL migration: a task test checks fallback logic with different runtime version, and it needs to reset all details including cache keys, hence the new scope on each run. This change preserves the backing temp db between such runs.
  • The fallback_test.dart change is mostly indent (with the wrapper method).
  • Refactored the PrimaryDatabase initialization, I think the new logic has better separation on which cases will trigger a temp db creation and cleanup.

@isoos isoos requested review from jonasfj and sigurdm November 20, 2025 11:10
@isoos isoos merged commit 7f9e0eb into dart-lang:master Nov 20, 2025
45 of 46 checks passed
@isoos isoos deleted the env-db branch November 20, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants