Version 3.0.0

Merge 3.0.0-417.4.beta into stable

Author: Dart CI

.github/ISSUE_TEMPLATE/2_cherry_pick.yml

@@ -4,7 +4,6 @@ title: '[CP] <title>'
 labels: ['cherry-pick-review']
 assignees:
   - mit-mit
-  - whesse
   - athomas
   - vsmenon
   - itsjustkevin

.github/ISSUE_TEMPLATE/3_breaking_change.yml

@@ -0,0 +1,28 @@
+name: Propose a breaking change.
+description: You would like to propose a breaking change.
+title: '[breaking change] <title>'
+labels: ['breaking-change-request']
+assignees:
+  - itsjustkevin
+  - kevmoo
+body:
+  - type: textarea
+    id: change_intent
+    attributes:
+      label: Change Intent
+      description: What is the intent of this change?
+  - type: textarea
+    id: justification
+    attributes:
+      label: Justification
+      description: What is the justification for this change?
+  - type: textarea
+    id: impact
+    attributes:
+      label: Impact
+      description: What is the impact of this change?
+  - type: textarea
+    id: mitigation
+    attributes:
+      label: Mitigation
+      description: How can we mitigate the impact?

.github/workflows/scorecards-analysis.yml

@@ -23,12 +23,12 @@ jobs:
 
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
+        uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3
         with:
           persist-credentials: false
 
       - name: "Run analysis"
-        uses: ossf/scorecard-action@99c53751e09b9529366343771cc321ec74e9bd3d
+        uses: ossf/scorecard-action@e38b1902ae4f44df626f11ba0734b14fb91f8f86
         with:
           results_file: results.sarif
           results_format: sarif
@@ -43,14 +43,14 @@ jobs:
 
       # Upload the results as artifacts (optional).
       - name: "Upload artifact"
-        uses: actions/upload-artifact@83fd05a356d7e2593de66fc9913b3002723633cb
+        uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce
         with:
           name: SARIF file
           path: results.sarif
           retention-days: 5
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: "Upload to code-scanning"
-        uses: github/codeql-action/upload-sarif@c3b6fce4ee2ca25bc1066aa3bf73962fda0e8898
+        uses: github/codeql-action/upload-sarif@67a35a08586135a9573f4327e904ecbf517a882d
         with:
           sarif_file: results.sarif

BUILD.gn

@@ -5,11 +5,11 @@
 import("build/config/gclient_args.gni")
 import("sdk_args.gni")
 
-targetting_fuchsia = target_os == "fuchsia"
+targeting_fuchsia = target_os == "fuchsia"
 
 # This target will be built if no target is specified when invoking ninja.
 group("default") {
-  if (targetting_fuchsia) {
+  if (targeting_fuchsia) {
     # Fuchsia has run_vm_tests marked testonly.
     testonly = true
   }
@@ -18,7 +18,7 @@ group("default") {
 
 group("most") {
   import("runtime/runtime_args.gni")
-  if (targetting_fuchsia) {
+  if (targeting_fuchsia) {
     # Fuchsia has run_vm_tests marked testonly.
     testonly = true
   }
@@ -35,7 +35,7 @@ group("most") {
 group("runtime") {
   import("runtime/runtime_args.gni")
 
-  if (targetting_fuchsia) {
+  if (targeting_fuchsia) {
     # Fuchsia has run_vm_tests marked testonly.
     testonly = true
   }
@@ -60,14 +60,18 @@ group("runtime") {
     ]
   }
 
-  # We do not support AOT on ia32 and should therefore not provide native
-  # snapshot tooling.
-  if (dart_target_arch != "ia32" && dart_target_arch != "x86") {
-    if (dart_runtime_mode == "release") {
-      deps += [ "runtime/bin:analyze_snapshot_product" ]
-    } else {
-      deps += [ "runtime/bin:analyze_snapshot" ]
-    }
+  # This flag is set in runtime/runtime_args.gni
+  # The analyze_snapshot tool is only supported on 64 bit AOT builds running
+  # under linux and android platforms
+  if (build_analyze_snapshot) {
+    deps += [
+      # The `analyze_snapshot` tests require the `analyze_snapshot` as well as
+      # `gen_snapshot` binaries.
+      "runtime/bin:analyze_snapshot",
+      "runtime/bin:analyze_snapshot($host_toolchain)",
+      "runtime/bin:gen_snapshot",
+      "runtime/bin:gen_snapshot($host_toolchain)",
+    ]
   }
 
   if (is_linux || is_android) {
@@ -189,7 +193,7 @@ if (is_fuchsia) {
       if (defined(invoker.data_deps)) {
         data_deps += invoker.data_deps
       }
-      manifest = "build/fuchsia/dart.cmx"
+      manifest = invoker.manifest
 
       library_files = []
       if (defined(invoker.library_files)) {
@@ -225,6 +229,7 @@ if (is_fuchsia) {
   }
 
   dart_fuchsia_test_component("fuchsia_test_component") {
+    manifest = "build/fuchsia/fuchsia_test_component.cmx"
     resource_dirs = [
       "tests/standalone_2",
       "pkg/async_helper",
@@ -253,6 +258,7 @@ if (is_fuchsia) {
   }
 
   dart_fuchsia_test_component("fuchsia_ffi_test_component") {
+    manifest = "build/fuchsia/fuchsia_ffi_test_component.cmx"
     data_deps = [
       "runtime/bin:ffi_test_dynamic_library",
       "runtime/bin:ffi_test_functions",